Conversation
Some widgets check the cursor position when handling the touch down event, so we need to make sure `cursor_position` is set then, and not only when there is a touch move event. Simply always setting it for `WindowEvent::PointerButton` (for touch or mouse input) seems reasonable. We also need to avoid clearing `cursor_position` for `PointerLeft` with a touch device. Do that only for mouse input. Ideally Iced would handle touch input without tying to `cursor_position`, but this should match the behavior of upstream Iced. This seems to fix regressions since the Iced rebase in the `tour` example, and in `cosmic-files`. `cosmic-files` seems to have some issue using the menus with a touch device, but that doesn't seem to be a regression.
wash2
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some widgets check the cursor position when handling the touch down event, so we need to make sure
cursor_positionis set then, and not only when there is a touch move event. Simply always setting it forWindowEvent::PointerButton(for touch or mouse input) seems reasonable.We also need to avoid clearing
cursor_positionforPointerLeftwith a touch device.Ideally Iced would handle touch input without tying to
cursor_position, but this should match the behavior of upstream Iced.This seems to fix regressions since the Iced rebase in the
tourexample, and incosmic-files.cosmic-filesseems to have some issue using the menus with a touch device, but that doesn't seem to be a regression.