Skip to content

Alternative admin group list, or perhaps testing access directly instead #81

@moll

Description

@moll

Hey,

It took me a few moments to realize why exactly Firmware Manager kept showing it's only for administrators. I first traced it down to https://github.com/pop-os/system76-firmware/blob/2a64993c8d7fc10f170f3707846b0221c4313f8a/data/system76-firmware-daemon.conf listing two groups as permitted parties. As I had configured sudo to use a different group than %sudo, I thought adding it to /etc/dbus-1/system.d/system76-firmware-daemon.conf would suffice. Turns out, however, that the permitted group list is also hardcoded into https://github.com/pop-os/firmware-manager/blob/df334aeb2b5e6b9df719ab1f2dddcdb08cdf475e/src/users.rs.

Wouldn't it be more robust to just try passing a DBUS message to FirmwareDaemon and seeing it that works, rather than assuming access based on the group?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions