client-toolkit: Add suport for cosmic-toplevel-info-v1 version 2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the API compatible, adding fields to `ToplevelInfo` for the foreign handle, identifier, and geometry. While also supporting version 1 if that's all the compositor exposes.
wash2
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the API compatible, adding fields to
ToplevelInfofor the foreign handle, identifier, and geometry. While also supporting version 1 if that's all the compositor exposes.This can be tested with the
toplevel-monitorexample, or anything else using this protocol. Change thebind_onecall from1..=2to1..=1to test it it's still working with version 1 of the protocol. In the future may want to replace this with a different API, possibly trying to support wlroots as well, but this seems like a good approach for now.