shell/grabs: Adjust reactive popups when window is moved #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reactive XDG popups should be reconstrained if the window is moved: > When set reactive, the surface is reconstrained if the conditions used for constraining changed, e.g. the parent window moved.
dcz-self
commented
Apr 23, 2025
| toplevel, | ||
| // TODO: give some thought to round vs floor | ||
| (location + offset.as_global().to_f64()).to_i32_round(), | ||
| self.window_outputs.iter(), |
There was a problem hiding this comment.
The outputs are for finding the anchor point and the anchor point must be within the surface, so it will be within the same outputs as the window, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XDG popups with positioner::reactive should be reconstrained if the window is moved:
This can be tested with the example from https://codeberg.org/dcz/stiwri :
This is what it looks like. Laggy because of my computer, but also I think I'm redrawing the surface one frame late.
The popup is allowed to slide to the right if the space to the left is not big enough. Its allowed to flip down if the space above is not big enough.
Screencast_20250423_145018.webm
Before this change, you needed to drag the edge and resize for the popup to move.
This will be very useful for the input method protocol update I'm working on.