Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Deploy server as an action and configure dependencies via newer pipenv #53

Merged
merged 106 commits into from
Mar 26, 2020

Conversation

avan1235
Copy link
Contributor

It's configured to refresh the data on server every time the push changes the django-server folder at any branch (so clean the server repo on heroku and push there all the files from server folder to setup server based on Pipfile)

.gitignore Outdated Show resolved Hide resolved
django-server/server/Procfile Outdated Show resolved Hide resolved
django-server/server/api/models.py Outdated Show resolved Hide resolved
django-server/server/api/views.py Show resolved Hide resolved
django-server/server/server/.env.sample Outdated Show resolved Hide resolved
django-server/server/server/settings.py Show resolved Hide resolved
django-server/server/server/urls.py Outdated Show resolved Hide resolved
django-server/server-env-setup.sh Show resolved Hide resolved
Copy link
Contributor

@Robert-Mic Robert-Mic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why .sample was deleted, otherwise it looks good :)

@avan1235 avan1235 requested a review from kantoniak March 25, 2020 18:32
.github/workflows/server_deploy.yaml Show resolved Hide resolved
django-server/server-env-setup.sh Show resolved Hide resolved
django-server/server/api/views.py Show resolved Hide resolved
@avan1235 avan1235 requested a review from kantoniak March 26, 2020 08:46
Copy link
Contributor

@kantoniak kantoniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but I think deploying form multiple branches is a big no-no.

@avan1235
Copy link
Contributor Author

can introduce testing deploy server as the separate action, then will change this action to be launched only on master branch

@avan1235 avan1235 merged commit ffef409 into master Mar 26, 2020
@avan1235 avan1235 deleted the avan1235/server-deploy branch March 26, 2020 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants