fix missing sha256sum command and print info for fish shell #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
requested changes
Feb 5, 2020
|
Can you also add 2 entries to the CHANGELOG as part of this PR?
|
Closed
SeanTAllen
reviewed
Feb 5, 2020
SeanTAllen
reviewed
Feb 5, 2020
SeanTAllen
reviewed
Feb 5, 2020
SeanTAllen
reviewed
Feb 5, 2020
|
Thank you very much for this @khaledez and welcome to folks who have contributed to the project. |
|
Thank you @SeanTAllen for your help and quick response! |
|
@khaledez you are welcome. FYI, Your change is going out in a release RIGHT NOW. So, how is that for instant gratification? |
|
Amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to install ponyup on my macOS machine, it was failing with this error:
sh: line 116: sha256sum: command not foundBut macOS Catalina comes with
shasumutility, so I made a change to check ifsha256sumis not available, then useshasum, otherwise just exit printing error.Also, I use fish shell which has a slightly different syntax, so I added a custom message for fish.