Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog-tool package #38

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add changelog-tool package #38

merged 1 commit into from
Nov 9, 2019

Conversation

Theodus
Copy link
Contributor

@Theodus Theodus commented Nov 9, 2019

Closes #29

Copy link
Member

@SeanTAllen SeanTAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except, I think for the $(tty) change that I believe is the source of the test failure.

@Theodus
Copy link
Contributor Author

Theodus commented Nov 9, 2019

Yeah, I did that because otherwise it would create a file called not a tty for some reason

@Theodus
Copy link
Contributor Author

Theodus commented Nov 9, 2019

This may fail due to cloudsmith being down: https://api.cloudsmith.io/

@SeanTAllen
Copy link
Member

@Theodus I'm going to merge, if it isn't Cloudsmith we can fix later. a better "Cloudsmith is down message" would be good. maybe make checking the API a part of tests?

@SeanTAllen SeanTAllen merged commit ba21609 into master Nov 9, 2019
@SeanTAllen SeanTAllen deleted the changelog-tool branch November 9, 2019 23:49
SeanTAllen added a commit that referenced this pull request Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add changelog-tool to managed projects
2 participants