Safely call 'cancel' on Android even if lateinit property 'mToast' had not been initialized beforehand #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialized beforehand This covers cases where we call 'cancel' the very first time, even if no Toast had ever been displayed beforehand.
|
I actually have the same use case, and would be great to get it handled as you described. |
|
@abianche Until @ponnamkarthik releases a new version on pub.dev, you can actually reference the Git commit containing the changes here, by adding this to your fluttertoast:
git:
url: https://github.com/PonnamKarthik/FlutterToast
ref: cb70da0093d4323002c730219aae7c255a648a0aThis will make Flutter clone this repo at the exact merge commit (cb70da0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
cancelbeforeshowToastmakes apps crash with the following Kotlin exception message:lateinit property mToast not initialized.In my apps, I needed to "cancel" any pending Toasts (before they disappear on their own) prior to displaying new ones, and this is why I stumbled upon this particular corner case. Rather than explicitly handling that very first interaction with FlutterToast, I thought it would be more useful to just do nothing if
cancelis called without a prior call toshowToast.Feel free to close this PR if you think it doesn't make sense.
Thanks!