[fitting] Local basis refactor by nmellado · Pull Request #177 · poncateam/ponca

nmellado · 2025-07-11T13:53:45Z

This PR adds :

A way to make weighting functions that can either use global or local basis (DistWeightFunc and NoWeightFunc were expanded to implement this).
The barycenter.cpp test to validate this new feature in the CI.
Moves the projectDescent function to the Basket concept, as this can be shared across Fits.

Todo

Check if changelog reflects the changes (e.g project descent).
Check that fits that do not support global support trigger an error for global basis
Check how to properly implement changeBasis in primitives.

Ponca/src/Fitting/weightFunc.h

Me-k-01 · 2025-07-17T08:47:29Z

.github/workflows/testAsSubmodule.yml


      - name: Checkout helper repository with Ponca as submodule (master branch)
-        run: git clone https://github.com/poncateam/ci-submodule-helper.git repo
+        run: git clone https://github.com/Me-k-01/ci-submodule-helper.git -b local-basis repo


Todo before merging :

Change this link back to the main branch, and in the ci-submodule-helper repo, merge the PR 2 to the master

Suggested change

run: git clone https://github.com/Me-k-01/ci-submodule-helper.git -b local-basis repo

run: git clone https://github.com/poncateam/ci-submodule-helper.git repo

Because of the refactor in the [PR 177](poncateam/ponca#177)

Me-k-01 · 2025-09-05T13:02:19Z

@nmellado As discussed outside of GitHub, I've removed the project function from the NeighborFilter when isLocal = False, to prevent the user from using this function on inappropriate Fit.
Can you review the changes?

Me-k-01 · 2025-09-09T12:29:44Z

Ready for review @nmellado

nmellado

First (partial) round of comments.

Ponca/src/Fitting/basket.h

Ponca/src/Fitting/dryFit.h

Ponca/src/Fitting/primitive.h

tests/src/scale_space_consistency.cpp

tests/src/projection.cpp

tests/src/normal_plane.cpp

tests/src/gls_tau.cpp

tests/src/gls_sphere_der.cpp

doc/src/ponca_module_fitting.mdoc

Ponca/src/Fitting/weightFunc.h

Ponca/src/Fitting/primitive.h

Ponca/src/Fitting/plane.h

Signed-off-by: fauberva <florian.auberval@irit.fr>

And tweaking the values of the sphere point cloud for better barycenter results Signed-off-by: fauberva <florian.auberval@irit.fr>

Signed-off-by: fauberva <florian.auberval@irit.fr>

- support to compact/non compact kernels - better represent centerbasis for transparent use of global and local basis in downstream code

Bug was triggered for planar cases

Signed-off-by: fauberva <florian.auberval@irit.fr>

- Use this API is AlgebraicSphere

- also add tests

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 linked an issue Jul 15, 2025 that may be closed by this pull request

Continue to improve weights computation API #174

Open

Me-k-01 removed a link to an issue Jul 15, 2025

Continue to improve weights computation API #174

Open

Me-k-01 linked an issue Jul 15, 2025 that may be closed by this pull request

add bases classes for local/global fit #178

Closed

Me-k-01 force-pushed the local_basis branch 3 times, most recently from ddfc575 to 533faa8 Compare July 15, 2025 08:18

Me-k-01 reviewed Jul 16, 2025

View reviewed changes

Ponca/src/Fitting/weightFunc.h Outdated Show resolved Hide resolved

Me-k-01 mentioned this pull request Jul 16, 2025

Renaming setWeightFunc to setNeighborFilter poncateam/ci-submodule-helper#2

Merged

nmellado force-pushed the local_basis branch from ee46dc1 to ff22c30 Compare July 16, 2025 12:17

Me-k-01 reviewed Jul 17, 2025

View reviewed changes

Me-k-01 mentioned this pull request Jul 17, 2025

TODO : Review the comments and fix some typos #181

Closed

Me-k-01 pushed a commit to Me-k-01/poncaplot that referenced this pull request Jul 22, 2025

Ponca : API change relating WeightFunc

48e5e31

Because of the refactor in the [PR 177](poncateam/ponca#177)

Me-k-01 mentioned this pull request Jul 22, 2025

Ponca : API change relating WeightFunc poncateam/poncaplot#19

Closed

Me-k-01 force-pushed the local_basis branch 3 times, most recently from 446c43b to 5f10ecb Compare July 22, 2025 11:44

Me-k-01 added the help wanted Extra attention is needed label Aug 29, 2025

This comment was marked as resolved.

Sign in to view

Me-k-01 removed the help wanted Extra attention is needed label Sep 5, 2025

Me-k-01 self-requested a review September 5, 2025 12:54

Me-k-01 marked this pull request as ready for review September 5, 2025 13:45

Me-k-01 force-pushed the local_basis branch 2 times, most recently from a641e8d to 8352f8f Compare September 9, 2025 09:48

Me-k-01 self-assigned this Sep 9, 2025

nmellado commented Sep 9, 2025

View reviewed changes

Me-k-01 force-pushed the local_basis branch 2 times, most recently from 0e76c9b to 241058e Compare September 9, 2025 13:13

nmellado commented Sep 9, 2025

View reviewed changes

fauberva and others added 16 commits October 30, 2025 14:58

[fitting] Rename to camel case the boolean param

a48c349

Signed-off-by: fauberva <florian.auberval@irit.fr>

[fitting] Pass isLocal to the base in NoWeightFunc

a9d2fd6

Signed-off-by: fauberva <florian.auberval@irit.fr>

[tests] Activating the center offset in the barycenter test

61ff13d

And tweaking the values of the sphere point cloud for better barycenter results Signed-off-by: fauberva <florian.auberval@irit.fr>

[ci] Fix codacy

ce6d4e9

Signed-off-by: fauberva <florian.auberval@irit.fr>

Update CHANGELOG

c0e40da

[Fitting] Remove deprecated method basisCenter

b7d0293

[Fitting] Clarify API + fix tests

ab24f48

[fitting] Modify WeightFunc proposal

894d6eb

- support to compact/non compact kernels - better represent centerbasis for transparent use of global and local basis in downstream code

[fitting] Fix bug in Algebraic::project function

c81206d

Bug was triggered for planar cases

[tests] Update projection test with local/global and compact/noncompact

b9c8def

Update CHANGELOG

2d87f3e

[Fitting] Add GaussianWeightKernel

9d4d421

[fitting] Fix gaussian first derivative

7b3bb1b

Signed-off-by: fauberva <florian.auberval@irit.fr>

[Fitting] Add API to changeNeighborhoodFrame

d5d8e1e

- Use this API is AlgebraicSphere

[fitting] Add changeBasis to Plane and Line primitives

9166dee

- also add tests

Update CHANGELOG

9c5b317

nmellado force-pushed the local_basis branch from 2d892a9 to 9c5b317 Compare October 30, 2025 18:58

nmellado merged commit 9e7681e into master Oct 30, 2025
10 of 12 checks passed

nmellado deleted the local_basis branch October 30, 2025 19:01

Me-k-01 pushed a commit that referenced this pull request Nov 24, 2025

[fitting] Rename _WFunctor to _NFilter (Refactor #177)

38ad165

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 pushed a commit that referenced this pull request Nov 24, 2025

[fitting] Update according to refactor #177

7667c19

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 pushed a commit that referenced this pull request Nov 24, 2025

[fitting] Update according to PR #177 refactor

f649114

Signed-off-by: fauberva <florian.auberval@irit.fr>

nmellado pushed a commit to jmaleo/ponca that referenced this pull request Dec 2, 2025

[fitting] Rename _WFunctor to _NFilter (Refactor poncateam#177)

4e68bff

Signed-off-by: fauberva <florian.auberval@irit.fr>

nmellado pushed a commit to jmaleo/ponca that referenced this pull request Dec 2, 2025

[fitting] Update according to refactor poncateam#177

9388519

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 pushed a commit to jmaleo/ponca that referenced this pull request Dec 10, 2025

[fitting] Rename _WFunctor to _NFilter (Refactor poncateam#177)

10a57d5

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 pushed a commit to jmaleo/ponca that referenced this pull request Dec 10, 2025

[fitting] Update according to refactor poncateam#177

259f433

Signed-off-by: fauberva <florian.auberval@irit.fr>

nmellado pushed a commit to jmaleo/ponca that referenced this pull request Jan 19, 2026

[fitting] Rename _WFunctor to _NFilter (Refactor poncateam#177)

14c58c1

Signed-off-by: fauberva <florian.auberval@irit.fr>

nmellado pushed a commit to jmaleo/ponca that referenced this pull request Jan 19, 2026

[fitting] Update according to refactor poncateam#177

0363ed8

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 pushed a commit to jmaleo/ponca that referenced this pull request Jan 26, 2026

[fitting] Rename _WFunctor to _NFilter (Refactor poncateam#177)

7dc4a20

Signed-off-by: fauberva <florian.auberval@irit.fr>

Me-k-01 pushed a commit to jmaleo/ponca that referenced this pull request Jan 26, 2026

[fitting] Update according to refactor poncateam#177

910a4b6

Signed-off-by: fauberva <florian.auberval@irit.fr>

	run: git clone https://github.com/Me-k-01/ci-submodule-helper.git -b local-basis repo
	run: git clone https://github.com/poncateam/ci-submodule-helper.git repo

Conversation

nmellado commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Me-k-01 Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Todo before merging :

Uh oh!

This comment was marked as resolved.

Me-k-01 commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Me-k-01 commented Sep 9, 2025

Uh oh!

nmellado left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nmellado commented Jul 11, 2025 •

edited

Loading

Me-k-01 Jul 17, 2025 •

edited

Loading

Me-k-01 commented Sep 5, 2025 •

edited

Loading