update X/Twitter logo #1454
Merged
update X/Twitter logo #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update font-awesome link to a newer version that includes a newer X/Twitter logo. Something changed about the way the CSS is structured, such that loading just the brands.min.css file is not sufficient to apply the proper font-family setting, so tweak custom.css to fix this.
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ZPain8464
approved these changes
Jun 17, 2024
Contributor
ZPain8464
left a comment
ZPain8464
left a comment
There was a problem hiding this comment.
Thanks for updating this, @kenjenkins. Looks good!
backport-actions-token bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Update font-awesome link to a newer version that includes a newer X/Twitter logo. Something changed about the way the CSS is structured, such that loading just the brands.min.css file is not sufficient to apply the proper font-family setting, so tweak custom.css to fix this.
Merged
kenjenkins
added a commit
that referenced
this pull request
Jun 17, 2024
update X/Twitter logo (#1454) Update font-awesome link to a newer version that includes a newer X/Twitter logo. Something changed about the way the CSS is structured, such that loading just the brands.min.css file is not sufficient to apply the proper font-family setting, so tweak custom.css to fix this. Co-authored-by: Kenneth Jenkins <51246568+kenjenkins@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update font-awesome link to a newer version that includes a newer X/Twitter logo. Something changed about the way the CSS is structured, such that loading just the brands.min.css file is not sufficient to apply the proper font-family setting, so tweak custom.css to fix this.
Related issue: