Fix global shortcut PiP when no active tab #821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the global shortcut for the
PiPcommand sometimes fails to start Picture-in-Picture when Chrome does not provide an active tab to thechrome.commandshandler.Previously,
getAutoMediawould return early whentabInfowas undefined, so in those cases no media element was selected and thePiPcommand did nothing. Now, whentabInfois missing we still score all known media items and pick the best candidate, while continuing to respect pinned media and existing PiP when available.Testing:
NODE_ENV=development npm run build:common) and loaded it unpacked in Chrome.command Aas a global shortcut mapped toPiPwith value statetoggle.tabInfois missing.