Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom type errors from Member #429

Merged
merged 6 commits into from
Nov 16, 2021
Merged

Remove custom type errors from Member #429

merged 6 commits into from
Nov 16, 2021

Conversation

isovector
Copy link
Member

@isovector isovector commented Nov 16, 2021

This PR removes custom type errors from usages of Member. Now that polysemy-plugin is stable, most of the catchable, useful errors are now magically solved. What remain are mostly over-eager errors that get in the way of seeing real type errors.

Removing custom errors cleans up a lot of tickets, and as a bonus, is a lot of red.

In the real world, this is a significant improvement in polysemy's code generation. When building Galley.API.Public from wireapp/wire-server#1917, this change is:

- terms: 16,086
+ terms: 16,978
- types: 7,910,353
+ types: 7,916,780
- coercions: 13,919,222
+ coercions: 5,551,380
- ppr core size: 951956810
+ ppr core size: 361974977

Notice that coercions are down by 60%, and that the core size is 1/3.

This is a breaking change and needs a major version bump.

Fixes #107
Fixes #154
Fixes #227
Fixes #363
Fixes #341
Fixes #426

@isovector isovector merged commit 5515064 into master Nov 16, 2021
@isovector isovector deleted the no-tyeqs branch November 16, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment