Remove custom type errors from Member #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes custom type errors from usages of
Member
. Now thatpolysemy-plugin
is stable, most of the catchable, useful errors are now magically solved. What remain are mostly over-eager errors that get in the way of seeing real type errors.Removing custom errors cleans up a lot of tickets, and as a bonus, is a lot of red.
In the real world, this is a significant improvement in polysemy's code generation. When building
Galley.API.Public
from wireapp/wire-server#1917, this change is:Notice that coercions are down by 60%, and that the core size is 1/3.
This is a breaking change and needs a major version bump.
Fixes #107
Fixes #154
Fixes #227
Fixes #363
Fixes #341
Fixes #426