Feature/cabal doctest and ghc 8.8.1 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Haskell build tools run in slightly different environments (meaning different package databases are available). - The nixpkgs build for polysemy-plugin is failing due to a missing package database, which causes the doctest to fail (more information here: NixOS/nixpkgs#71164). - By using cabal-doctest we can expose the Haskell packages required to the doctests no matter the build tool we're using.
Closed
- Use @googleson78 's changes to build polysemy on GHC 8.8.1, with slight modifications. The source distribution is now found in "dist-newstyle/sdist", so we've updated the command to point at that folder. Additionally, cabal v2-install doesn't support installing .tar.gz files in the same way v1-install did, so updated the command to use "cabal v1-install". - Modified polysemy to use "cabal-doctest" and so overcome issues with the doctest tests (see issue polysemy-research#258, PR polysemy-research#265).
sevanspowell
force-pushed
the
feature/cabal-doctest-and-ghc-8.8.1
branch
from
d2af1d1 to
a4fe8ef
Compare
|
This is amazing, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a WIP so I can hit the CI on behalf of @googleson78 and #258