Fix strictness semantics of State and Writer #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
reviewed
Jul 28, 2019
| @@ -24,6 +24,7 @@ module Polysemy.Internal.Combinators | |||
|
|
|||
| import qualified Control.Monad.Trans.State.Lazy as LS | |||
| import qualified Control.Monad.Trans.State.Strict as S | |||
| import qualified Data.Tuple as S (swap) | |||
There was a problem hiding this comment.
The swap defined in this module was my attemp to get around runFixpoint diverging. I don't think it's necessary anymore.
There was a problem hiding this comment.
It's not, since the fixpoint tests I added still succeed. Still, maybe we want the lazy swap for runLazyState?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #192 and closes #193