Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inlining to Polysemy.Writer #170

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

KingoftheHomeless
Copy link
Collaborator

I forgot to add those wacky INLINE pragmas...

@isovector
Copy link
Member

I wonder if we could convince Loopbreaker to insert these automatically. @TheMatten any ideas?

@isovector isovector merged commit fff2c96 into polysemy-research:master Jul 8, 2019
@TheMatten
Copy link
Collaborator

You mean something like INLINE to all functions that manipulate Sem type, or all functions in module?

@isovector
Copy link
Member

Just things that are wrappers around send.

@isovector
Copy link
Member

I think it's a good idea to manually mark your interpreters as INLINE, but the actions should technically be INLINEABLE CONLIKE, which is more of a mouthful than I want to ask from users. The TH correctly generates the right stuff.

@TheMatten
Copy link
Collaborator

Generally (and this should be compatible with reimplementation in the future), I would like to have {-# ANN foo Loopbreaker #-}, that would just "do it's magic" and add required annotations and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants