Textual and Visual Algebra Exploration #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary substitution for documents to improve performance
…rom ddlManager and catalog methods
…to algebra-exploration
…ing null error for polyAlg tests
…ded handling for concurrent delays for testing
datomo
approved these changes
Dec 16, 2024
Member
datomo
left a comment
datomo
left a comment
There was a problem hiding this comment.
This look good to me (except the sometimes single failing tests...)!
Member
|
This and UI are both good for me @vogti . Thx @tobias-weber |
vogti
approved these changes
Feb 1, 2025
Member
vogti
left a comment
vogti
left a comment
There was a problem hiding this comment.
Thx, @tobias-weber and @datomo, for this amazing contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances Polypheny with the ability to serialize arbitrary query plans into a textual representation called PolyAlgebra. This is the foundation for the new framework-based plan editor system in the UI. The required functionality is provided via new HTTP endpoints and websocket messages.
Changes
Removed the old query plan builder
Replaced the old InformationQueryPlan with InformationPolyAlg for the new plan editor
Changed the order of information pages for executed queries to be grouped by statements
Added
Optionalfor multiple cost and count metadata @datomoChanged
CyclicMetadataExceptionto followGenericRuntimeException@datomoFeatures
Tests
ToDo
CYPHER_EXTRACT_FROM_PATH, then enable corresponding tests inPolyAlgParsingTestbindArguments()and staticcreate()method). This can also be done at a later point, as it is only required for the rare use case of editing physical plans.