Skip to content

Interfaces for managing Continuous Recording #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Interfaces for managing Continuous Recording #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a47b669
Retention management services
Oct 31, 2025
73d3915
List continuous recordings service
Nov 5, 2025
f2542a0
Delete recording interface
Nov 6, 2025
4211716
datetime and retain recording interfaces
Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ rosidl_generate_interfaces(${PROJECT_NAME}
"srv/ListBagRecordings.srv"
"srv/DeleteMap.srv"
"srv/ListMaps.srv"
"srv/StartBagRetention.srv"
"srv/StopBagRetention.srv"
"action/GenerateOfflineMap.action"
DEPENDENCIES ${dependencies}
)
Expand Down
13 changes: 13 additions & 0 deletions srv/StartBagRetention.srv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
## Request

# Session suffix (optional, recommended)
string session_suffix

---
## Response

# Indicate successful run of service
bool success

# Error messages
string error
9 changes: 9 additions & 0 deletions srv/StopBagRetention.srv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
## Request
Copy link
Contributor

@troygibb troygibb Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how generic this .srv is, why not just make it something like BasicRequest.srv?

Copy link
Contributor Author

@dhruvtya dhruvtya Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can make a basic trigger request, since even StopBagRecording.srv is the same

---
## Response

# Indicate successful run of service
bool success

# Error messages
string error