Conversation
0c494b1 to
42f82a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving type safety and robustness across the codebase, particularly around configuration, HTTP handling, and data encoding. The changes introduce stricter type checks, better error handling, and enhanced static analysis, which should help prevent subtle bugs and make the code easier to maintain.
Type safety and validation improvements:
Configconstructor to ensure all configuration options are of the expected type before assignment. This prevents invalid types from being silently accepted.Eip712Signer::encodeValueby adding checks for expected types (stringforstringandaddress,intforuint256) and throwing descriptive exceptions if the types do not match.HTTP client and response handling:
GuzzleHttpClientby ensuring headers are always arrays before merging and normalizing, and by adding type annotations for better static analysis. [1] [2] [3]Response::jsonmethod to throw a custom exception if the decoded JSON is not an array, ensuring downstream code always receives the expected structure.Response::headermethod to guarantee it returns a string ornull, never an unexpected type.Static analysis and documentation:
ClobAuthenticatorto improve static analysis and code clarity. [1] [2]