Remove unnecessary ajax request to get users #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this thinking. Could you please rebase from master so we don't lose Mark's recent commit? |
|
I added him back |
|
Ok. I'm in a poker tourney. Ill merge this later, or one of the other guys can. :) Sent from my iPhone On 09/03/2014, at 11:36 AM, Sebastian Porto notifications@github.com wrote:
|
|
Thanks @sporto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why have the users in an additional json file? It just creates an unnecessary ajax request. This PR just moves the users into the main js file so the site loads faster. Feel free to reject!