Skip to content

Support New Business Products #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

aitzkovitz
Copy link
Contributor

No description provided.

Copy link
Contributor

@mmoghaddam385 mmoghaddam385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are you planning on releasing this or is there more to add? Don't forget to update the version before releasing: https://github.com/polygon-io/client-jvm#notes-for-maintainers

Copy link

@morningvera morningvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aitzkovitz
Copy link
Contributor Author

LGTM, are you planning on releasing this or is there more to add? Don't forget to update the version before releasing: https://github.com/polygon-io/client-jvm#notes-for-maintainers

good call. Do i need to manually release to maven using that gradle task?

@mmoghaddam385
Copy link
Contributor

LGTM, are you planning on releasing this or is there more to add? Don't forget to update the version before releasing: https://github.com/polygon-io/client-jvm#notes-for-maintainers

good call. Do i need to manually release to maven using that gradle task?

@aitzkovitz no you don't need to do anything special, updating the version in code there is just so the user agent is accurate. When you create a Github release you should see the new version appear on jitpack pretty quickly

@aitzkovitz aitzkovitz merged commit e154916 into master Oct 25, 2023
@aitzkovitz aitzkovitz deleted the ai.support-new-business-products branch October 25, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants