Skip to content

Update require syntax in examples to use import instead. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

timetraveler328
Copy link
Collaborator

I also updated the client initialization to use an env variable so you should be able to easily run any example like POLY_API_KEY=yourAPIKey node examples/rest/crypto-aggregates_bars.js. Added the dependencies needed to run the websocket examples as dev dependencies, so those can be run too.

…les to you env variable so they can easily be run from the command line
Copy link
Contributor

@justinpolygon justinpolygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, really nice idea on the api key from the env!

@timetraveler328 timetraveler328 merged commit ef43990 into master Aug 11, 2023
@timetraveler328 timetraveler328 deleted the fix/example-syntax branch August 11, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants