Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning 206, if a namespace can't be parsed #258

Merged
merged 10 commits into from
Dec 8, 2022
Merged

Conversation

tengstrand
Copy link
Collaborator

@tengstrand tengstrand commented Nov 5, 2022

Adds this warning, which can be displayed with the check command:

  Warning 206 - Unreadable namespace in brick/project.
    Triggered if a namespace can't be parsed for a brick or project.

The poly tool now checks if the namespace for a component, base, or project, can be parsed, and shows a warning otherwise (fully commented out namespaces are just ignored).

Closes #251
Closes #254

@tengstrand tengstrand changed the title Issue 254 Show warning 206, if a namespace can't be parsed Nov 5, 2022
@@ -1,4 +1,4 @@
Poly 0.2.16-alpha-issue247 (2022-10-27) - https://github.com/polyfy/polylith
Poly 0.2.16-alpha-issue254 (2022-11-04) - https://github.com/polyfy/polylith
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is 2022-11-05 in version component. It's better if they are the same.

@tengstrand tengstrand merged commit 28d8848 into master Dec 8, 2022
@tengstrand tengstrand deleted the issue-254 branch December 8, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants