Emptish objects fail to roundtrip cbor marshal & unmarshal

[dignifiedquire]

Trying some simple edge cases and got these issues

Emptyish objects that fail to round trip

(fmt.Printf("%s - %s\n", obj, reflect.TypeOf(obj)))

• [] - interface[]{}: panic: cborEncoder stack overpopped (marshal)
• [<nil>] - interface[]{}: Invalid majorByte: 0xff (unmarshal)
• <nil> - %!s(<nil)): panic: cborEncoder stack overpopped (marshal)

(Setup is as described in #9)

[warpfork]

Ok, I think all these are fixed on master as well.

Thank you for this heroic and excellent bug reporting!

(I'm particularly embarrassed in this case -- there were fixtures on the token side meant to cover precisely these cases... but no mappings defined on the matching the cbor side. It's to the point I should be writing tests to make sure the texts are fully filling out the $n*m$ matrix...!)

[dignifiedquire]

Thanks for the quick turn around, I have some more issues I am afraid

• [] gets turned into nil if I round trip it
• {"a":"IPFS","b":null,"c":[1]} gets turned into {"a":"IPFS","b":"IPFS","c":[1]} in a round trip

[dignifiedquire]

It would probably be useful to add a bunch of test vectors, making sure things work as expected. Some I have used in the past and might be useful

• official cbor test vectors https://github.com/dignifiedquire/borc/blob/master/test/fixtures/vectors.js
• various vectors discovered over time: https://github.com/dignifiedquire/borc/blob/master/test/fixtures/cases.js
• fuzzing using something that generates arbitrary JSON and making sure roundtripping gives the same data: https://github.com/dignifiedquire/borc/blob/master/test/garbage.spec.js

[warpfork]

Sorry E_TIME_BUDGET happened a bit... I'll try to allocate some time this evening.

At first glance, these are probably issues with nil-vs-typed-nil being handled inconsistently in the obj mapper package rather than a cbor problem. So I'll be focusing on adding unit tests and fixtures there.

Those borc tools look useful...! Maybe with a little work I can rig them around the refmt CLI tool to get a lot of acceptance test coverage there. Though this might require some rather odd subcommands like refmt cbor=obj=cbor, which would have very little sensible purpose other than testing.

[warpfork]

Fixed the issue with nulls, thanks.

I can't reproduce your issue with []. Am I missing something?

[dignifiedquire]

Thanks, I'll check it out. There is always the chance my code is the issue :)

[dignifiedquire]

Turns out the [] was an issue on our side thanks a lot for the work.

[warpfork]

Even more test coverage is a very acceptable "problem" to have as a sideeffect :)