Skip to content

Commit

Permalink
chore: fix regression tests
Browse files Browse the repository at this point in the history
Regression tests were explicitly copying files that no longer
exist into target destination, and therefore failed.

Stop copying those files, we were doing it to fix a specific
release when this was introduced, no longer applicable.
  • Loading branch information
rix0rrr authored May 14, 2020
1 parent ff8219b commit 0f948a4
Showing 1 changed file with 6 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/bin/bash
#
# Run our integration tests in regression mode against the
#
# Run our integration tests in regression mode against the
# local code of the framework and CLI.
#
#
# 1. Download the latest released version of the aws-cdk repo.
# 2. Copy its integration tests directory ((test/integ/cli)) here.
# 3. Run the integration tests from the copied directory.
Expand Down Expand Up @@ -39,8 +39,8 @@ function download_repo {

# we need to download the repo code from GitHub in order to extract
# the integration tests that were present in that version of the repo.
# TODO - consider switching this to 'npm install',
# apparently we publish the integ tests in the package.
# TODO - consider switching this to 'npm install',
# apparently we publish the integ tests in the package.
version=$1

out="${temp_dir}/.repo.tar.gz"
Expand Down Expand Up @@ -69,10 +69,6 @@ integ_under_test=${integdir}/cli-backwards-tests-${sanitized_version}
rm -rf ${integ_under_test}
echo "Copying integration tests of version ${VERSION_UNDER_TEST} to ${integ_under_test} (dont worry, its gitignored)"
cp -r ${temp_dir}/packages/aws-cdk/test/integ/cli ${integ_under_test}
echo "Copying test runner to integration tests of version ${VERSION_UNDER_TEST}"
cp -r ${integdir}/cli/test.sh ${integ_under_test}/test.sh
echo "Copying common.bash to integration tests of version ${VERSION_UNDER_TEST}"
cp -r ${integdir}/cli/common.bash ${integ_under_test}/common.bash

echo "Running integration tests of version ${VERSION_UNDER_TEST} from ${integ_under_test}"
VERSION_UNDER_TEST=${VERSION_UNDER_TEST} ${integ_under_test}/test.sh
VERSION_UNDER_TEST=${VERSION_UNDER_TEST} ${integ_under_test}/test.sh

0 comments on commit 0f948a4

Please sign in to comment.