Open
Conversation
polubis
requested changes
Jan 20, 2021
Owner
polubis
left a comment
polubis
left a comment
There was a problem hiding this comment.
Please move io-fdk folder to src directory - because right now will be problematic to use this outside of src directory
tsconfig.json
Outdated
| "utils": ["src/utils"], | ||
| "services*": ["src/services/*"], | ||
| "styles": ["src/styles"], | ||
| "comparision": ["io-fdk/comparision"] |
Owner
There was a problem hiding this comment.
Path should be src/io-fdk
comparision key should be changed to io-fdk and also same for path
| @@ -0,0 +1,15 @@ | |||
| import { isRefType } from ".."; | |||
|
|
|||
Owner
There was a problem hiding this comment.
This file should be named isRefType.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.