Open
Conversation
ajronn
approved these changes
Jan 8, 2021
polubis
requested changes
Jan 8, 2021
Owner
polubis
left a comment
polubis
left a comment
There was a problem hiding this comment.
Great work. A few things to improve
| @@ -0,0 +1,48 @@ | |||
| const path = require('path'); | |||
Owner
There was a problem hiding this comment.
We should create file which is called webpack utils - and in this file we exporting only pure functions which return configuration objects for scss, tsx, etc and we should use this file in main.js and also webpack.config.js.
This approach will reduce issues after webpack refactor or version update in future
| "@babel/core": "^7.8.3", | ||
| "@babel/preset-env": "^7.8.3", | ||
| "@babel/preset-react": "^7.8.3", | ||
| "@babel/preset-typescript": "^7.12.7", |
Owner
There was a problem hiding this comment.
This lib is needed by storybook ?
| addons: ['@storybook/addon-links', '@storybook/addon-essentials'], | ||
| webpackFinal: async (config, mode) => { | ||
| config.resolve.plugins.push(new TsConfigPaths({})); | ||
| config.resolve.alias['styles'] = path.resolve(__dirname, '../src/styles'); |
Owner
There was a problem hiding this comment.
You can add variable for ../src/styles - just suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MISSING: