Improve input conversion logic in BaseBytes component #11562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR addresses a regression where input for Bytes component starting with
0xare incorrectly parsed as hex-encoded byte strings. This caused issues where display names like0xTaylorwere misparsed as hex bytes (e.g.,0x0a0000), leading to incorrect rendering.This update improves the logic by only interpreting a string as hex if it is a valid hex sequence. Non-hex strings starting with
0xare now correctly treated as plain text.🤔 Previous behaviour
✅ Current behaviour
Screen.Recording.2025-05-16.at.10.47.36.mov