Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcm benchmarking for encointer runtime #440

Merged

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Aug 20, 2024

closes #199

Add xcm benchmark setup for encointer-kusama-runtime

  • Does not require a CHANGELOG entry

@brenzi
Copy link
Contributor Author

brenzi commented Aug 20, 2024

@bkontur With the example of the people chain, I added XCM benchmarks to encointer, but pallet-xcm-benchmarks::generic fails because of skipped benchmarks, whereas people accepts these skips. I seem to be missing some config.

I did:

cargo build -p chain-spec-generator --profile production --features runtime-benchmarks
./target/production/chain-spec-generator --raw encointer-kusama-local > encointer-kusama-chain-spec.json
~/bin/polkadot-parachain-v1.14.0-runtime-benchmarks benchmark pallet --chain ./encointer-kusama-chain-spec.json --pallet=pallet-xcm-benchmarks::generic --extrinsic="*"

which throws errors. change encointer- to people- and it works

edit: fixed in 7d2e67c

@brenzi brenzi changed the title add xcm benchmarking for encointer runtime. along people chain add xcm benchmarking for encointer runtime Aug 20, 2024
@brenzi brenzi changed the title add xcm benchmarking for encointer runtime xcm benchmarking for encointer runtime Aug 20, 2024
@brenzi brenzi marked this pull request as ready for review August 23, 2024 12:09
brenzi and others added 2 commits August 23, 2024 15:31
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr
Copy link
Contributor

bkchr commented Aug 25, 2024

@brenzi could you please format the code correctly? CI is not happy :D

@bkontur
Copy link
Contributor

bkontur commented Aug 25, 2024

@bkontur With the example of the people chain, I added XCM benchmarks to encointer, but pallet-xcm-benchmarks::generic fails because of skipped benchmarks, whereas people accepts these skips. I seem to be missing some config.

I did:

cargo build -p chain-spec-generator --profile production --features runtime-benchmarks
./target/production/chain-spec-generator --raw encointer-kusama-local > encointer-kusama-chain-spec.json
~/bin/polkadot-parachain-v1.14.0-runtime-benchmarks benchmark pallet --chain ./encointer-kusama-chain-spec.json --pallet=pallet-xcm-benchmarks::generic --extrinsic="*"

which throws errors. change encointer- to people- and it works

edit: fixed in 7d2e67c

@brenzi can you merge this one please: encointer#1 ? It fixes the benchmarks for pallet_xcm which fail here: https://github.com/polkadot-fellows/runtimes/actions/runs/10528553477/job/29174892572?pr=440
(and also I did fmt)

bkontur and others added 2 commits August 25, 2024 11:45
@brenzi
Copy link
Contributor Author

brenzi commented Aug 25, 2024

@bkontur thanks for your fix.
This also includes one-line changes in other systemchains (coretime and people). Was that on purpose? Seems out of context to this PR, but I don't mind

@brenzi
Copy link
Contributor Author

brenzi commented Aug 25, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) August 25, 2024 20:12
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 421f303 into polkadot-fellows:main Aug 25, 2024
48 checks passed
@brenzi brenzi mentioned this pull request Aug 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encointer checks/improvements
5 participants