Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #648

Merged
merged 12 commits into from
May 11, 2022
Merged

Improve CI #648

merged 12 commits into from
May 11, 2022

Conversation

koushiro
Copy link
Collaborator

@koushiro koushiro commented Apr 27, 2022

Signed-off-by: koushiro koushiro.cqx@gmail.com

waiting for #645 to be merged firstly

maybe we should add rust-toolchain.toml for this repo, like:

[toolchain]
channel = "nightly-2022-05-02"
components = ["rustfmt", "clippy"]
targets = ["wasm32-unknown-unknown"]

@koushiro koushiro requested a review from sorpaas as a code owner April 27, 2022 15:30
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro mentioned this pull request May 9, 2022
@sorpaas
Copy link
Member

sorpaas commented May 10, 2022

The changes unfortunately breaks branch protection rules. Is it possible to change the name of the job back without (nightly-2022-05-02) part? Otherwise we'd need to modify the protection rules every time we update Rust.

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Copy link
Collaborator Author

@sorpaas PTAL

@sorpaas sorpaas merged commit b370c60 into polkadot-evm:master May 11, 2022
@koushiro koushiro deleted the improve-ci branch May 11, 2022 02:51
koushiro added a commit to alt-research/frontier that referenced this pull request May 12, 2022
* Improve CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Use nightly-2022-05-02

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Remove useless submodule

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make test more stable

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* remove strategy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
* Improve CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Use nightly-2022-05-02

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Remove useless submodule

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make test more stable

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* remove strategy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants