Schema cache rework + background task tests setup #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/rpc/src/eth.rs # client/rpc/src/lib.rs
|
@sorpaas could you review please? |
sorpaas
approved these changes
Apr 25, 2022
Merged
18 tasks
32 tasks
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Schema cache task rework using block import * Use parent id * Add test for background task * fmt * Update Cargo.lock * Remove unused tokio * Cleanup * Add license * Template runtime feature aura * Handle reorgs and test * Add `tempfile` dev-dependency * Move `cache` mod + tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
storage_changes_notification_streamforpallet-ethereumschema cache background task proved to be wrong.The reason is storage change notifications are blindly emitted by substrate on import, without caring about blocks marked as best or re-org situations.
Proposal
This PR simplifies the background task to react to block import notifications instead, doing minimal work to guarantee the cache is up to date:
pallet-ethereumschema change.retracted/enactedbranches contained in thenotification.Tests
We don't test the background tasks. I added the ones that covers this cases, if it gets approved I will work on the tests for the remaining background tasks.