Introduce EVMFungibleAdapter #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadkaouk
changed the title
|
Please merge this to master! @ahmadkaouk Thanks. I just find this is a critically broken change for the users of this repo. |
benefacto
approved these changes
May 3, 2024
There was a problem hiding this comment.
Our team would also appreciate having this changed merged as soon as possible as pallet_transaction_payment::CurrencyAdapter is already documented as deprecated and overdue to be removed entirely (March 2024).
boundless-forest
approved these changes
May 6, 2024
boundless-forest
pushed a commit
to darwinia-network/frontier
that referenced
this pull request
May 7, 2024
* new EVMFungibleAdapter struct * Update comment
AurevoirXavier
pushed a commit
to darwinia-network/frontier
that referenced
this pull request
May 7, 2024
* new EVMFungibleAdapter struct * Update comment Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com>
AurevoirXavier
pushed a commit
to darwinia-network/frontier
that referenced
this pull request
Jun 25, 2024
* new EVMFungibleAdapter struct * Update comment Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
EVMFungibleAdapter, equivalent toEVMCurrencyAdapterbut forfungibletraits. This is in preparation for the deprecation of theCurrencyTrait and migration tofungible(see paritytech/polkadot-sdk#226).Similar to
FungibleAdapterofpallet_transaction_paymenthere.