-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pending runtime api for pending state #1160
fix: pending runtime api for pending state #1160
Conversation
cc @tgmichel |
I am curious why the CI does not report this issue in the prs easier merged. |
If CI reports error, then the previous wrong implementation obviously cannot be merged into the master branch. What you should care about is why the original implementation and later fix are wrong. The original implementation only considered And the author of later fix PR maybe do not understand the mechanism of the runtime api and aura consensus, I don't know why this fix PR can be merged into master branch :( |
Usually we shouldn't add breaking changes in release branch, but in this case since it was simply broken let's just fix that this way. |
@koushiro @sorpaas We have a problem with the new implementation of pending state, the new closure Unfortunately, we can't just provide an implementation of To solve this problem, we need a way of knowing that we're in the "pending" context and apply a different check in this context (allow same relay number). What do you think? Do you see a better solution? |
The original design of pending runtime API was wrong, and the later fix about using the aura consensus were also problematic.
See #1123 (comment) for more details
Close #1149