Remove vendor substrate #115
Conversation
|
I suspect I need to do similar changes to other two vendor repos to actually make this usable by other projects. |
|
The block import (including the clone part) is already done on this PR: #113 |
|
Can we also consider removing the |
template/node/Cargo.toml
Outdated
| sc-consensus = { version = "0.8.0-dev", path = "../../vendor/substrate/client/consensus/common" } | ||
| sp-timestamp = { version = "2.0.0-dev", default-features = false, path = "../../vendor/substrate/primitives/timestamp" } | ||
| evm = { version = "2.0.0-dev", package = "pallet-evm", path = "../../vendor/substrate/frame/evm" } | ||
| sp-api = { version = "2.0.0-dev", git = "https://github.com/paritytech/substrate.git", rev = "8a35a14c2dd91bc5de77366f45a06fe45bdfd1d6" } |
There was a problem hiding this comment.
Maybe just branch = "master" and pin commit in Cargo.lock?
There was a problem hiding this comment.
It will be hard to make sure the pinned version doesn't get updated when adding new deps
There was a problem hiding this comment.
https://github.com/paritytech/polkadot repo does use this strategy though. Another worry for me is how do we get this large amount of dependency pins updated each time.
There was a problem hiding this comment.
Global search & replace is easy enough.
Polkadot can constantly keep up to date because Substrate PR must have a companion Polkadot PR to fix the broken part. Unless frontier have same treatment, I don’t think pin to master branch is good idea.
There was a problem hiding this comment.
I agree with @sorpaas that updating the revision number is inconvenient, specially when switching from multiple remotes and versions during development.
There was a problem hiding this comment.
During development, you can use local version of substrate by updating your cargo config, see read me update in this PR
There was a problem hiding this comment.
I will prefer to pin to a branch instead of master, similar how cumulus is currently doing. But someone will need to setup that branch in Substrate first.
There was a problem hiding this comment.
@xlc I created frontier branch in Substrate. Please update this PR to use that.
|
As Substrate is updated, I included #111 as well |
xlc
force-pushed
the
refactor-substrate
branch
from
5a6556e to
9963951
Compare
xlc
force-pushed
the
refactor-substrate
branch
from
9963951 to
6ed1bcb
Compare
* remove Substrate as submodule, use git reference directly instead * add instruction * impl Clone for FrontierBlockImport * remove evm as well * use frontier branch * update with latest master credits to @crystalin
Closes #112
Using the same Substrate commit
Also fixed build issue on template runtime.