-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsRef
and AsMut
for AccountId20
#1139
Add AsRef
and AsMut
for AccountId20
#1139
Conversation
components = ["rustfmt", "clippy"] | ||
targets = ["wasm32-unknown-unknown"] | ||
profile = "minimal" | ||
channel = "nightly-2023-05-22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boundless-forest why change the rust-toolchain config in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use the same rust toolchain config of polkadot releases (https://github.com/paritytech/polkadot/releases/tag/v1.0.0)
channel="nightly-2023-05-22"
is not 8b4b20836
rustup show
nightly-2023-05-23-aarch64-apple-darwin
rustc 1.71.0-nightly (8b4b20836 2023-05-22)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nightly-2023-05-22 is not 8b4b20836
Why? rustc 1.71.0-nightly (8b4b20836 2023-05-22)
I understand the 8b4b20836
is the nightly version id of the 2023-05-22
.
Is this output misleading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could try to run the command rustup show
in the frontier workspace and you didn't change the toolchain of CI at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I see your point. How about updating this later in next PR?
* Update toolchain toml config * Add helper functions
Check out implementations for the AccountId32. https://paritytech.github.io/substrate/master/sp_runtime/struct.AccountId32.html#