Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global review #259

Merged
merged 23 commits into from
Oct 11, 2021
Merged

Global review #259

merged 23 commits into from
Oct 11, 2021

Conversation

sacha-l
Copy link

@sacha-l sacha-l commented Oct 10, 2021

This PR is a general pass on content to address miscellaneous issues, including:

@netlify
Copy link

netlify bot commented Oct 10, 2021

✔️ Deploy Preview for substrate-docs ready!

🔨 Explore the source changes: 9115582

🔍 Inspect the deploy log: https://app.netlify.com/sites/substrate-docs/deploys/6163be8699c48c0007b4538c

😎 Browse the preview: https://deploy-preview-259--substrate-docs.netlify.app

@netlify
Copy link

netlify bot commented Oct 10, 2021

✔️ Deploy Preview for substrate-docs-staging ready!

🔨 Explore the source changes: 9115582

🔍 Inspect the deploy log: https://app.netlify.com/sites/substrate-docs-staging/deploys/6163be86808c7a0008afced7

😎 Browse the preview: https://deploy-preview-259--substrate-docs-staging.netlify.app

v3/tutorials/05-private-network/index.mdx Outdated Show resolved Hide resolved
Jimmy Chu and others added 2 commits October 11, 2021 12:29
# Conflicts:
#	v3/how-to-guides/07-parachains/c-reserve-id/index.mdx
#	v3/how-to-guides/07-parachains/f-start-testnet/index.mdx
@jimmychu0807 jimmychu0807 merged commit ab632e5 into develop Oct 11, 2021
@jimmychu0807 jimmychu0807 deleted the sl/global-review branch October 11, 2021 04:34
@nuke-web3
Copy link
Contributor

Just wanted to check in on this - were the TODOs fixed in this PR, or just removed? If the latter, let's please highlight them in #179

@sacha-l
Copy link
Author

sacha-l commented Oct 20, 2021

@nukemandan : The TODOS for parachain how-to guides that were removed were in relation to adding Examples and References. There are still some that were left in (global search: FIXME). What this PR is saying in relation to closing the TODO issues (#158) is that #179 will handle the remaining fixes because all that remains is very parachain content specific. And it's already highlighted with the "FIXME TODO" or "TODO:FIXME" markdown notes ;)

@nuke-web3
Copy link
Contributor

What #158 was about was keeping an open issue to ensure there were no lingering TODO:FIXME times left at all if I understood correctly - Perhaps a new tracking issue is needed for this that excludes anything that isn't covered in #179? Happy to do this if we need it then. I will add a note in 179

@sacha-l
Copy link
Author

sacha-l commented Oct 21, 2021

I don't think having 2 issues for the same thing is necessary. In this case, we already have issues open about completing parachain content. It turns out the only FIXMEs / TODOs we have outstanding are for that content AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants