Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples and tutorials for deprecated index #2054

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Update examples and tutorials for deprecated index #2054

merged 3 commits into from
Sep 7, 2023

Conversation

Rashmirreddy
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for substrate-docs ready!

Name Link
🔨 Latest commit aef8d05
🔍 Latest deploy log https://app.netlify.com/sites/substrate-docs/deploys/64f87a2c4b2e860007fe1810
😎 Deploy Preview https://deploy-preview-2054--substrate-docs.netlify.app/tutorials/build-application-logic/specify-the-origin-for-a-call
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rashmirreddy
Copy link
Contributor Author

fixes "#2035"

juangirini
juangirini suggested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes on content/md/en/docs/tutorials/build-application-logic/specify-the-origin-for-a-call.md are incorrect. The other two files are ok

@Rashmirreddy Rashmirreddy marked this pull request as ready for review September 6, 2023 13:10
juangirini
juangirini approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rashmirreddy Rashmirreddy merged commit 0e5e832 into main Sep 7, 2023
5 of 6 checks passed
@Rashmirreddy Rashmirreddy deleted the Update-examples-and-tutorials-for-deprecated-Index branch September 7, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangirini juangirini juangirini approved these changes

@wentelteefje wentelteefje wentelteefje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rashmirreddy @juangirini @wentelteefje