-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cumulus Tutorial Refactor & Update #203
Conversation
@jimmychu0807 let's integrate updates here for polkadot launch too 🙏 (per JoshOrndorff/cumulus-workshop#101) please make a PR into this PR's branch |
✔️ Deploy Preview for substrate-docs-staging ready! 🔨 Explore the source changes: 8e1d159 🔍 Inspect the deploy log: https://app.netlify.com/sites/substrate-docs-staging/deploys/616095cc7afb1e00087a51d5 😎 Browse the preview: https://deploy-preview-203--substrate-docs-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes are confined to cumulus related materials, specifically the tutorial v3/tutorials/09-cumulus/
files have content changes. folders renamed touched a lot of files, but as you can see, no changes in them.
@imadarai no formatting is added here (#210 includes these proposed changes) only the ignore file is left. All other non-mdx files have changes for the new page and naming only for you to approve 🙏
All mdx files I would love a review from anyone on the devhub team. I will move next to #239 (as there are braking changes in the links used in the HTGs 😭 )
@nukemandan I am reviewing this PR and add my update on this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged Develop again to remove conflicts and update recent changes. Some changes are pretty big - please refer to the message on Mattermost.
yarn dev
is notyarn develop
- You'll have to setup your local
.env.development
file using example (read README section 3) - For documentation port is now going to be
8001
instead of8000
Other than that everything looks good to me!
category: parachains | ||
duration: 3 Hours | ||
difficulty: 3 | ||
keywords: cumulus, relay chain, parachain, parathread, paraid, template, rococo, xcm, xcmp, collator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keywords: cumulus, relay chain, parachain, parathread, paraid, template, rococo, xcm, xcmp, collator | |
keywords: | |
[ | |
cumulus, | |
tutorial, | |
workshop, | |
parachain, | |
parathread, | |
paraid, | |
register, | |
template, | |
rococo, | |
parathread, | |
xcm, | |
xcmp, | |
relay chain, | |
collator, | |
] |
cc @jimmychu0807 you reverted this change.
This works on my end, and IMHO the more keywords the better for the search engine to pick this up in context, right?
There are still issues I will address in #179 to patch this up, but it's in a good state to merge and make incremental small changes moving forward 🎉 |
closes #133
<Message\>
in dark mode doesn't work with code snippets #231 bug fix