Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus Tutorial Refactor & Update #203

Merged
merged 34 commits into from
Oct 8, 2021
Merged

Cumulus Tutorial Refactor & Update #203

merged 34 commits into from
Oct 8, 2021

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Oct 5, 2021

@nuke-web3 nuke-web3 changed the title [WIP] Cumulus Worksop Update [WIP] Cumulus Workshop Update Oct 5, 2021
@nuke-web3 nuke-web3 marked this pull request as draft October 5, 2021 01:45
@nuke-web3 nuke-web3 self-assigned this Oct 5, 2021
@nuke-web3 nuke-web3 added the ⛔ DO NOT MERGE ⛔ WIP! Changes needed. label Oct 5, 2021
@nuke-web3
Copy link
Contributor Author

@jimmychu0807 let's integrate updates here for polkadot launch too 🙏 (per JoshOrndorff/cumulus-workshop#101)

please make a PR into this PR's branch

@nuke-web3 nuke-web3 changed the base branch from main to develop October 6, 2021 19:48
@netlify
Copy link

netlify bot commented Oct 6, 2021

✔️ Deploy Preview for substrate-docs-staging ready!

🔨 Explore the source changes: 8e1d159

🔍 Inspect the deploy log: https://app.netlify.com/sites/substrate-docs-staging/deploys/616095cc7afb1e00087a51d5

😎 Browse the preview: https://deploy-preview-203--substrate-docs-staging.netlify.app

@polkadot-developers polkadot-developers deleted a comment from netlify bot Oct 6, 2021
@nuke-web3 nuke-web3 mentioned this pull request Oct 6, 2021
@nuke-web3
Copy link
Contributor Author

nuke-web3 commented Oct 6, 2021

I can't get the footer nav buttons to work as expected (like the ink workshop does) what am I missing @sacha-l / @imadarai ?

The buttons in the footer nav to move about pages also do not work :(

Related to #205

Copy link
Contributor Author

@nuke-web3 nuke-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are confined to cumulus related materials, specifically the tutorial v3/tutorials/09-cumulus/ files have content changes. folders renamed touched a lot of files, but as you can see, no changes in them.

@imadarai no formatting is added here (#210 includes these proposed changes) only the ignore file is left. All other non-mdx files have changes for the new page and naming only for you to approve 🙏

All mdx files I would love a review from anyone on the devhub team. I will move next to #239 (as there are braking changes in the links used in the HTGs 😭 )

@nuke-web3 nuke-web3 marked this pull request as ready for review October 7, 2021 19:35
@nuke-web3 nuke-web3 changed the title [WIP] Cumulus Workshop Update Cumulus Tutorial Refactor & Update Oct 7, 2021
@nuke-web3 nuke-web3 mentioned this pull request Oct 7, 2021
14 tasks
@jimmychu0807
Copy link

jimmychu0807 commented Oct 8, 2021

@nukemandan I am reviewing this PR and add my update on this branch

Copy link

@imadarai imadarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged Develop again to remove conflicts and update recent changes. Some changes are pretty big - please refer to the message on Mattermost.

  • yarn dev is not yarn develop
  • You'll have to setup your local .env.development file using example (read README section 3)
  • For documentation port is now going to be 8001 instead of 8000

Other than that everything looks good to me!

@nuke-web3 nuke-web3 added devhub and removed ⛔ DO NOT MERGE ⛔ WIP! Changes needed. labels Oct 8, 2021
category: parachains
duration: 3 Hours
difficulty: 3
keywords: cumulus, relay chain, parachain, parathread, paraid, template, rococo, xcm, xcmp, collator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keywords: cumulus, relay chain, parachain, parathread, paraid, template, rococo, xcm, xcmp, collator
keywords:
[
cumulus,
tutorial,
workshop,
parachain,
parathread,
paraid,
register,
template,
rococo,
parathread,
xcm,
xcmp,
relay chain,
collator,
]

cc @jimmychu0807 you reverted this change.
This works on my end, and IMHO the more keywords the better for the search engine to pick this up in context, right?

@nuke-web3
Copy link
Contributor Author

There are still issues I will address in #179 to patch this up, but it's in a good state to merge and make incremental small changes moving forward 🎉

@nuke-web3 nuke-web3 merged commit 3a0711d into develop Oct 8, 2021
@nuke-web3 nuke-web3 deleted the cumulus-update-main branch October 8, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update & Test 09-cumulus-workshop
3 participants