[WIP] Example comparator diffs #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kowal please rebase on top of master |
kowal
force-pushed
the
example-comparator-diffs
branch
from
cbb0a70 to
02c3511
Compare
|
@nijikon rebased |
|
will review that soon |
kowal
force-pushed
the
example-comparator-diffs
branch
from
02c3511 to
964fd8d
Compare
|
@kowal Please rebase. |
kowal
force-pushed
the
example-comparator-diffs
branch
from
964fd8d to
4dc0a61
Compare
kowal
force-pushed
the
example-comparator-diffs
branch
from
8f2ce76 to
e7ba9a9
Compare
kowal
force-pushed
the
example-comparator-diffs
branch
from
e7ba9a9 to
d54bafb
Compare
kowal
force-pushed
the
example-comparator-diffs
branch
from
d54bafb to
2f656cf
Compare
|
Is this still a wip? |
|
it's been a while :) as far as I remember I've struggled with displaying configs diffs in output, so that it is readable what have changed. |
|
@kowal can you rebase to master? |
|
I am on vacations till next Thursday. When i get back i'll take a look at
this.
pt., 12.05.2017, 18:34 użytkownik Maciej Mensfeld <notifications@github.com>
napisał:
… @kowal <https://github.com/kowal> can you rebase to master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAApqVnpN7vFCkC0Prz60YZKMp0j-0jMks5r5IoogaJpZM4Gk-J->
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress.
As first step I wanted to replace current Hash extension (
#same_key_structure?) with#diffmethod in order to have actual difference of compared files, not just the flag.Next step is to build some useful output based on received diff from two hashes (actually we're only interested in keys structure, not the values).