Skip to content

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Feb 20, 2025

Two endpoints were added to support ARC/PLC projections
/pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/current
/pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/proposed

Both have been deployed to dev instance.

@navarroc
Copy link
Contributor

The programs are ARC and PLC so I think the endpoint should be:
/pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/current
/pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/proposed

@ylyangtw
Copy link
Contributor Author

The programs are ARC and PLC so I think the endpoint should be: /pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/current /pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/proposed

Thanks! It's been addressed!

@ylyangtw ylyangtw linked an issue Mar 3, 2025 that may be closed by this pull request
Copy link
Contributor

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the front end, and everything works well. Approving this PR.

@ylyangtw, I have a quick question: Could you confirm that the mean and median values are available only for subprograms (e.g., ALC and PLC) and not for the total program? I'm working on the mean value map and want to ensure it's displayed only in the appropriate context.

ylyangtw and others added 7 commits April 1, 2025 13:59
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Copy link
Member

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Briefly went through the changes. It looks good to me. I will approve.

@ylyangtw ylyangtw merged commit 470a97d into develop Apr 23, 2025
1 check passed
@ylyangtw ylyangtw deleted the 305-feature-add-endpoints-proposals-and-current-to-support-new-model-h branch April 23, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Henrique's model has 'NaN' in JSON [FEATURE] Add endpoints (proposals and current) to support new model H
4 participants