-
Notifications
You must be signed in to change notification settings - Fork 1
305 feature add endpoints proposals and current to support new model h #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
305 feature add endpoints proposals and current to support new model h #308
Conversation
The programs are ARC and PLC so I think the endpoint should be: |
Thanks! It's been addressed! |
…urrent-to-support-new-model-h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the front end, and everything works well. Approving this PR.
@ylyangtw, I have a quick question: Could you confirm that the mean and median values are available only for subprograms (e.g., ALC and PLC) and not for the total program? I'm working on the mean value map and want to ensure it's displayed only in the appropriate context.
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
Co-authored-by: Sandeep Puthanveetil Satheesan <sandeeps@illinois.edu>
…urrent-to-support-new-model-h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Briefly went through the changes. It looks good to me. I will approve.
Two endpoints were added to support ARC/PLC projections
/pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/current
/pdl/titles/title-i/subtitles/subtitle-a/arc-plc-payments/proposed
Both have been deployed to dev instance.