Fix for issue #6780 : benefits: file upload of 2 GB fails with correc… #7143
+182
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with correct buffers
|
@vin-dKR is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
|
hi @psincraian this is my latest PR i have closed the previous PR due to some conflicts. Please review this new PR. |
psincraian
requested changes
Oct 8, 2025
| """Schema to create a file to be associated with the downloadables benefit.""" | ||
|
|
||
| service: Literal[FileServiceTypes.downloadable] | ||
| size: int = Field( |
There was a problem hiding this comment.
Why is this attribute needed? If you add it here, you should provide a value in the model if not you cannot download it.
psincraian
reviewed
Oct 8, 2025
| name: this.file.name, | ||
| size: this.file.size, | ||
| mime_type: mimeType, | ||
| checksum_sha256_base64: sha256base64, |
There was a problem hiding this comment.
The checksum has been removed; this creates a data integrity risk for corrupted files.
My recommendation is to implement an incremental checksum per chunk and verify it server side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #6780 where file uploads larger than 2 GB were failing.
Closes #6780
Changes
Fileobject per chunk (no full-file reads).bufferand implemented throughfileinstead inUpload.tsTesting
github.mp4