Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #97] refactor polaris-go examples #99

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

chuntaojun
Copy link
Member

@chuntaojun chuntaojun commented Sep 30, 2022

Please provide issue(s) of this PR:
Fixes #97

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun chuntaojun changed the title Refactor examples [ISSUE #80] refactor polaris-go examples Sep 30, 2022
@chuntaojun chuntaojun changed the title [ISSUE #80] refactor polaris-go examples [ISSUE #97] refactor polaris-go examples Sep 30, 2022
Copy link
Member

@shichaoyuan shichaoyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuntaojun chuntaojun merged commit f6933b0 into polarismesh:main Sep 30, 2022
@chuntaojun chuntaojun linked an issue Oct 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants