This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Added support for SE301 carrier with SOM1-SOC mezzanine from SundanceDSP #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman.K <roman.k@sundancedsp.com>
|
Hi @Mans-sdsp, could you please add a MAINTAINERS file to your board/sundancedsp/som1soc/ directory please? |
|
There's 2 commits in this PR, one being a merge. Can you rebase out that merge please? |
ConchuOD
suggested changes
Mar 27, 2024
|
|
||
| / { | ||
| model = "SundanceDSP SE301 REV0P0 VER1 SOM1SOC"; | ||
| compatible = "microchip,mpfs"; |
There was a problem hiding this comment.
Can you please add a device-specific compatible here for the som1? Pretty sure you can look at the polarberry and do what was done there here (but obv. with "som1" instead of "polarberry!).
| ti,fifo-depth = <0x01>; | ||
| }; | ||
|
|
||
| // phy5: ethernet-phy@5 { |
There was a problem hiding this comment.
Can you please remove commented "code" if the hardware doesn't exist or use status = "disabled" if it is present but you don't want to have it enabled
| board_name=som1soc | ||
| vendor=sundancedsp | ||
| baudrate=115200 | ||
| soc=polarfire |
There was a problem hiding this comment.
should soc here not be mpfs to match the naming elsewhere?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for SE301 carrier with SOM1-SOC mezzanine from SundanceDSP