Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix feature for pylist #96

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Aug 14, 2024

PyList is only used in the DataType::Struct arm of this file - was this meant to be "dtype-struct"?

I noticed this while updating the plugins tutorial

Without this, I get:

error[E0433]: failed to resolve: use of undeclared type `PyList`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyo3-polars-0.16.0/src/types.rs:475:30
    |
475 |                 let fields = PyList::new_bound(py, iter);
    |                              ^^^^^^ use of undeclared type `PyList`
    |
help: a struct with a similar name exists
    |
475 |                 let fields = PyDict::new_bound(py, iter);
    |                              ~~~~~~
help: consider importing this struct
    |
1   + use pyo3::types::PyList;

@MarcoGorelli MarcoGorelli marked this pull request as ready for review August 14, 2024 17:33
@ritchie46
Copy link
Member

Ah.. Do we need a patch?

@MarcoGorelli
Copy link
Contributor Author

i think so (if it's not too much bother), thanks 🙏

@ritchie46 ritchie46 merged commit a40590d into pola-rs:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants