fix: Fix libc::write argument type. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
reviewed
Sep 11, 2024
rust-toolchain.toml
Outdated
| @@ -1,2 +1,2 @@ | |||
| [toolchain] | |||
| channel = "nightly-2024-07-26" | |||
There was a problem hiding this comment.
Yes, sorry I did not mean to include this change.
The argument type for libc::write is platform dependent. The fix converts to the platform specific type using `TryInto`. This fixes Windows builds. Fixes pola-rs#101.
jetuk
force-pushed
the
fix-windows-libc-write-count-type
branch
from
557a883
to
2c53a52
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument type for libc::write is platform dependent. The fix converts to the platform specific type using
TryInto. This fixes Windows builds.Fixes #101.