fix(rust, python): implement missing conversion to python time
object
#5152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AnyValue::Time
match implementation forinto_py
was returning the underlying integer representation; this PR ensures that we now create proper python time objects instead.Was most apparent in calls to
DataFrame.rows()
for any frame containing time cols. (InterestinglySeries.to_list()
was fine, as theWrap
implementation forTimeChunked
handles it correctly).Example
Before: (raw integers)
After: (time values)
Note on updated unit tests
Quite a lot of the unit tests weren't actually validating the result; they were validating the shape of the result (which is how this one didn't get spotted earlier). I've updated most of the temporal unit tests such that they also check the returned values as well.
For example:
test_filter_time
would have caught this, but was written as...I've now updated it (and some others) to be more explicit, eg: