refactor: Disable recursive CSPE for now #25085
Merged
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp and
reswqa
as code owners
github-actions
bot
added
internal
Contributor
|
The uncompressed lib size after this PR is 48.1378 MB. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25085 +/- ##
==========================================
- Coverage 81.64% 81.64% -0.01%
==========================================
Files 1708 1708
Lines 235969 235963 -6
Branches 3005 3005
==========================================
- Hits 192667 192644 -23
- Misses 42534 42551 +17
Partials 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coastalwhite
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will hoist this to next release. Every cache inserts is also a predicate/ projection pushdown desision that needs to take other branches into account. It needs to reapply those pushdowns from subtrees. Will follow up later.