-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: Fix errors on native scan_iceberg
#23811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7d3d82e
to
3989c02
Compare
|
||
// # Note | ||
// This function mutates the IR node in-place rather than returning the new IR - the | ||
// StackOptimizer will re-call this function otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always want to mutate here, but we don't want the StackOptimizer
to re-call us.
scan_iceberg
scan_iceberg
scan_iceberg
scan_iceberg
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23811 +/- ##
==========================================
+ Coverage 81.38% 81.41% +0.02%
==========================================
Files 1653 1653
Lines 224519 224506 -13
Branches 2873 2873
==========================================
+ Hits 182718 182773 +55
+ Misses 41087 41019 -68
Partials 714 714 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
test_scan_iceberg_plain
#23842ARROW:schema
, causing us to go into a separate codepath for constructing the schema. This codepath has been updated in this PR to load the field IDs.