Skip to content

fix: Fix errors on native scan_iceberg #23811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jul 30, 2025

Changes

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jul 30, 2025

// # Note
// This function mutates the IR node in-place rather than returning the new IR - the
// StackOptimizer will re-call this function otherwise.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always want to mutate here, but we don't want the StackOptimizer to re-call us.

@nameexhaustion nameexhaustion changed the title feat: Default to native reader for scan_iceberg feat: Fix errors on native scan_iceberg Jul 31, 2025
@nameexhaustion nameexhaustion changed the title feat: Fix errors on native scan_iceberg fix: Fix errors on native scan_iceberg Jul 31, 2025
@github-actions github-actions bot added the fix Bug fix label Jul 31, 2025
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.41%. Comparing base (4b0f8dd) to head (27cdb8d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-parquet/src/arrow/read/schema/convert.rs 46.15% 7 Missing ⚠️
...polars-plan/src/plans/optimizer/expand_datasets.rs 88.63% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23811      +/-   ##
==========================================
+ Coverage   81.38%   81.41%   +0.02%     
==========================================
  Files        1653     1653              
  Lines      224519   224506      -13     
  Branches     2873     2873              
==========================================
+ Hits       182718   182773      +55     
+ Misses      41087    41019      -68     
  Partials      714      714              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Iceberg scan fails on test_scan_iceberg_plain Panic when collecting the same native Iceberg scan twice
1 participant