Skip to content

fix: Create file for streaming sink even if unspawned #23672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coastalwhite
Copy link
Collaborator

Fixes #23084.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 87.20000% with 48 lines in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (3588b2b) to head (805700e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lars-stream/src/nodes/io_sinks/partition/parted.rs 0.00% 38 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/mod.rs 65.51% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23672      +/-   ##
==========================================
- Coverage   81.30%   81.28%   -0.02%     
==========================================
  Files        1642     1642              
  Lines      223176   223362     +186     
  Branches     2837     2837              
==========================================
+ Hits       181447   181569     +122     
- Misses      41030    41094      +64     
  Partials      699      699              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite marked this pull request as draft July 22, 2025 15:16
@ritchie46
Copy link
Member

Nice, is this good to go. I think it can fix distributed.

@coastalwhite
Copy link
Collaborator Author

@orlp wanted to do it a bit differently. If he did his small refactor, I can rebase this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming cross join with empty left input doesn't create a file
2 participants