Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix csv offset #19319

Merged
merged 1 commit into from
Oct 19, 2024
Merged

refactor: Fix csv offset #19319

merged 1 commit into from
Oct 19, 2024

Conversation

ritchie46
Copy link
Member

fixes #19318

@ritchie46 ritchie46 added the skip changelog Do not include in changelog label Oct 19, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 19, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (bfdd496) to head (e116d49).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19319   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files        1523     1523           
  Lines      209530   209524    -6     
  Branches     2434     2434           
=======================================
+ Hits       168097   168098    +1     
+ Misses      40878    40871    -7     
  Partials      555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit dbc8368 into main Oct 19, 2024
27 checks passed
@ritchie46 ritchie46 deleted the csv branch October 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars skip changelog Do not include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_csv PanicException for trailing empty line
1 participant
@ritchie46