fix: Fix enum scalar output #19301
Merged
fix: Fix enum scalar output #19301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
ritchie46
commented
Oct 18, 2024
| @@ -85,16 +85,12 @@ impl EnumChunkedBuilder { | |||
| let length = arr.len() as IdxSize; | |||
| let ca = unsafe { | |||
| UInt32Chunked::new_with_dims( | |||
| Arc::new(Field::new( | |||
| self.name, | |||
| DataType::Enum(Some(self.rev.clone()), self.ordering), | |||
There was a problem hiding this comment.
Invariant: Always the same physical type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19301 +/- ##
==========================================
+ Coverage 80.00% 80.03% +0.02%
==========================================
Files 1528 1528
Lines 209850 209869 +19
Branches 2419 2419
==========================================
+ Hits 167894 167967 +73
+ Misses 41405 41351 -54
Partials 551 551 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19269